InstructionDurations from BackendV2 #11528

MozammilQ · 2024-01-09T17:25:46Z

Summary

This PR adds the support for BackendV2 in method from_backend of class InstructionDurations
in qiskit.transpiler.instruction_durations.py

Credit:
@nkanazawa1989 , for help and ideas :)

Details and comments

Earlier, InstructionDurations.from_backend() could support only BackendV1.
In this PR, now BackendV2 can also be passed into method from_backend.

…tionDurations

qiskit-bot · 2024-01-09T17:25:51Z

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@Qiskit/terra-core

mtreinish · 2024-01-09T17:43:41Z

qiskit/transpiler/instruction_durations.py

+        elif isinstance(backend, BackendV2):
+            target = backend.target
+            inst_with_no_props = {"delay"}
+            inst_duration = None
+            for name in target.operation_names:
+                for qubits, inst_props in target._gate_map[name].items():
+                    if name in inst_with_no_props:
+                        # Setting the duration for 'delay' to zero.
+                        inst_duration = 0.0
+                    else:
+                        try:
+                            inst_duration = inst_props.duration
+                        except AttributeError:
+                            logger.info("%s on %s did not report any duration", name, qubits)
+                            continue
+                    instruction_durations.append((name, qubits, inst_duration, "s"))
+
+            try:
+                dt = target.dt
+            except AttributeError:
+                logger.info("Backend Target didn't report any dt")


Why not just use backend.target.durations() (https://docs.quantum.ibm.com/api/qiskit/qiskit.transpiler.Target#durations)? It should already have most of this logic present in there so you can make this branch one line.

@mtreinish , Haha! :) I was working on a different PR, I discovered InstructionDurations.from_backend() didn't have the BackendV2 and did this PR.
A much better way: backend.target.durations() didn't cross my mind :)
Thanks, for the suggestion :)
I will add the suggestion :)

@mtreinish , added suggestion, please see if this is good enough :)

coveralls · 2024-01-09T19:15:42Z

Pull Request Test Coverage Report for Build 8315482005

Details

22 of 22 (100.0%) changed or added relevant lines in 1 file are covered.
10 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.008%) to 89.296%

Files with Coverage Reduction	New Missed Lines	%
qiskit/compiler/transpiler.py	2	91.96%
crates/qasm2/src/lex.rs	2	92.19%
crates/qasm2/src/parse.rs	6	97.15%

Totals
Change from base Build 8310563987:	0.008%
Covered Lines:	59791
Relevant Lines:	66958

💛 - Coveralls

nkanazawa1989 · 2024-01-18T16:17:15Z

.../notes/Add_support_for_BackendV2_in_instruction_durations_from_backend-9ce722879c870377.yaml

+    Given :code:`dt` and :code:`dtm` for a :class:`.BackendV1` or :class:`.BackendV2` are unequal,
+    :meth:`~.InstructionDurations.from_backend` does not raise any error.


Is there any change in code behavior with this PR? dtm is acquisition sampling rate and doesn't impact the instruction duration.

@nkanazawa1989 ,
According to,

qiskit/qiskit/transpiler/instruction_durations.py

Line 76 in 828ad4d

TranspilerError: If dt and dtm is different in the backend.

I should get TranspilerError if dt!=dtm, I just checked it, and found it doesn't.
So, I added this line in release note and added test test_works_unequal_dt_dtm to make sure this case is covered :)

The document should be wrong. See p.33 of https://arxiv.org/abs/1809.03452. dtm defines the sampling rate of digitizer, which can be independent of dt that defines the sampling rate of AWG.

I think this upgrade note is not necessary because TranspilerError was not actually raised (just accidentally documented).

.../notes/Add_support_for_BackendV2_in_instruction_durations_from_backend-9ce722879c870377.yaml

nkanazawa1989 · 2024-01-18T16:21:30Z

test/python/transpiler/test_instruction_durations.py

+        with self.assertRaises(TranspilerError):
+            durations.get(self.example_gate, self.example_qubit[0])
+
+    def test_works_unequal_dt_dtm(self):


What is the purpose of this test? InstructionDuration is the object used for scheduling, and dtm doesn't matter.

@nkanazawa1989 , This line was the motivation:

qiskit/qiskit/transpiler/instruction_durations.py

Line 76 in 828ad4d

TranspilerError: If dt and dtm is different in the backend.

Am I missing something

nkanazawa1989

Thanks @MozammilQ for updating the test and error handling. Several minor fix would be required but overall this PR is good to go.

nkanazawa1989 · 2024-02-15T06:35:53Z

.../notes/Add_support_for_BackendV2_in_instruction_durations_from_backend-9ce722879c870377.yaml

+    Given :code:`dt` and :code:`dtm` for a :class:`.BackendV1` or :class:`.BackendV2` are unequal,
+    :meth:`~.InstructionDurations.from_backend` does not raise any error.


I think this upgrade note is not necessary because TranspilerError was not actually raised (just accidentally documented).

test/python/transpiler/test_instruction_durations.py

MozammilQ · 2024-02-15T09:10:35Z

@nkanazawa1989 , see if this is good enough :)

jakelishman · 2024-02-15T10:10:15Z

@dieris: this PR is generally needed on Qiskit (for Qiskit 1.1 in 3 months' time), but I suspect might have some effects for work you did recently on qiskit-ibm-provider (and/or runtime) in Qiskit/qiskit-ibm-provider#787. Just flicking very quickly through the ibm-provider code, it looks like it'll handle things fine, but I'm just flagging this to you in case it affects anything.

dieris · 2024-02-15T14:43:23Z

@dieris: this PR is generally needed on Qiskit (for Qiskit 1.1 in 3 months' time), but I suspect might have some effects for work you did recently on qiskit-ibm-provider (and/or runtime) in Qiskit/qiskit-ibm-provider#787. Just flicking very quickly through the ibm-provider code, it looks like it'll handle things fine, but I'm just flagging this to you in case it affects anything.

yes, it looks like we had a similar idea, but the from_backend method in runtime/provider just overrides this one for the DynamicCircuitInstructionDurations subclass, so there are no conflicts.

nkanazawa1989 · 2024-02-20T18:23:48Z

.../notes/Add_support_for_BackendV2_in_instruction_durations_from_backend-9ce722879c870377.yaml

+    Support for :class:`.BackendV2` in :meth:`.InstructionDurations.from_backend` is added.
+
+    Users can have an object of :class:`.InstructionDurations` using :class:`.BackendV2`
+    from :meth:`.from_backend` with followig code.


Suggested change

from :meth:`.from_backend` with followig code.

from :meth:`.InstructionDurations.from_backend` with followig code.

to fix doc error

nkanazawa1989

Thanks @MozammilQ this looks good to me now, except for the docs generation failure. Can we merge this once all test pass?

MozammilQ · 2024-03-29T01:24:19Z

@nkanazawa1989 , Please, see if this is good enough :)

MozammilQ · 2024-10-29T22:42:12Z

@1ucian0 ,
pulse features are being deprecated in Qiskit, and being moved to Qiskit Dynamics, is this PR required anymore?
If yes, in what direction the PR should be heading?

MozammilQ added 3 commits January 9, 2024 11:30

Enabled support for BackendV2 in method from_backend of class Instruc…

f40808e

…tionDurations

added, modified tests

1c736b0

added release note

cf7fbd9

MozammilQ requested a review from a team as a code owner January 9, 2024 17:25

qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jan 9, 2024

mtreinish reviewed Jan 9, 2024

View reviewed changes

MozammilQ and others added 2 commits January 9, 2024 23:18

Merge branch 'main' into inst_dur_from_backendV2

c60f8ae

added suggestion, lint

7f3f763

MozammilQ added 3 commits January 9, 2024 19:22

fixed lint

2868b41

altered docstrings; added test; altered release note

7828930

fixed typo

8dd3fb4

nkanazawa1989 reviewed Jan 18, 2024

View reviewed changes

altered release note

795bf61

nkanazawa1989 reviewed Feb 15, 2024

View reviewed changes

nkanazawa1989 added the mod: transpiler Issues and PRs related to Transpiler label Feb 15, 2024

nkanazawa1989 self-assigned this Feb 15, 2024

MozammilQ and others added 2 commits February 15, 2024 08:45

added suggestions

a02ad0c

Merge branch 'main' into inst_dur_from_backendV2

5ccc547

jakelishman added the Changelog: New Feature Include in the "Added" section of the changelog label Feb 15, 2024

jakelishman added this to the 1.1.0 milestone Feb 15, 2024

MozammilQ and others added 3 commits February 16, 2024 13:59

added Generic Backends for tests

37229f8

Merge branch 'Qiskit:main' into inst_dur_from_backendV2

e91f71c

fix docs

55aca1c

nkanazawa1989 reviewed Feb 20, 2024

View reviewed changes

nkanazawa1989 previously approved these changes Feb 20, 2024

View reviewed changes

fix docs

bdbe82d

MozammilQ dismissed nkanazawa1989’s stale review via bdbe82d February 21, 2024 00:41

MozammilQ requested a review from nkanazawa1989 March 16, 2024 13:55

Merge branch 'main' into inst_dur_from_backendV2

2fe1a4f

jakelishman modified the milestones: 1.1.0, 1.2.0 Apr 11, 2024

ElePT removed this from the 1.2.0 milestone Jul 23, 2024

Merge branch 'main' into inst_dur_from_backendV2

7e357f1

Merge branch 'main' into inst_dur_from_backendV2

41ac00b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

InstructionDurations from BackendV2 #11528

InstructionDurations from BackendV2 #11528

MozammilQ commented Jan 9, 2024

qiskit-bot commented Jan 9, 2024

mtreinish Jan 9, 2024 •

edited

Loading

MozammilQ Jan 9, 2024 •

edited

Loading

MozammilQ Jan 9, 2024

coveralls commented Jan 9, 2024 •

edited

Loading

nkanazawa1989 Jan 18, 2024

MozammilQ Jan 18, 2024

nkanazawa1989 Feb 1, 2024 •

edited

Loading

nkanazawa1989 Feb 15, 2024

nkanazawa1989 Jan 18, 2024

MozammilQ Jan 18, 2024

nkanazawa1989 left a comment

nkanazawa1989 Feb 15, 2024

MozammilQ commented Feb 15, 2024 •

edited

Loading

jakelishman commented Feb 15, 2024

dieris commented Feb 15, 2024

nkanazawa1989 Feb 20, 2024

nkanazawa1989 left a comment

MozammilQ commented Mar 29, 2024

MozammilQ commented Oct 29, 2024

		Given :code:`dt` and :code:`dtm` for a :class:`.BackendV1` or :class:`.BackendV2` are unequal,
		:meth:`~.InstructionDurations.from_backend` does not raise any error.

	from :meth:`.from_backend` with followig code.
	from :meth:`.InstructionDurations.from_backend` with followig code.

InstructionDurations from BackendV2 #11528

Are you sure you want to change the base?

InstructionDurations from BackendV2 #11528

Conversation

MozammilQ commented Jan 9, 2024

Summary

Details and comments

qiskit-bot commented Jan 9, 2024

mtreinish Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

MozammilQ Jan 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jan 9, 2024 • edited Loading

Pull Request Test Coverage Report for Build 8315482005

Details

💛 - Coveralls

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nkanazawa1989 Feb 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nkanazawa1989 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MozammilQ commented Feb 15, 2024 • edited Loading

jakelishman commented Feb 15, 2024

dieris commented Feb 15, 2024

Choose a reason for hiding this comment

nkanazawa1989 left a comment

Choose a reason for hiding this comment

MozammilQ commented Mar 29, 2024

MozammilQ commented Oct 29, 2024

mtreinish Jan 9, 2024 •

edited

Loading

MozammilQ Jan 9, 2024 •

edited

Loading

coveralls commented Jan 9, 2024 •

edited

Loading

nkanazawa1989 Feb 1, 2024 •

edited

Loading

MozammilQ commented Feb 15, 2024 •

edited

Loading